watchdog: improve the behavior how watchdog is handled #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dlt_daemon_process_user_messages * dlt_daemon_send_ringbuffer_to_client * dlt_daemon_client_send_all_multiple * dlt_daemon_process_systemd_timer * dlt_daemon_handle_event * dlt_daemon_socket_sendreliable These methods can take longer than the systemd watchdog timeout allowed, depending on the number of clients, which leads that the systemd watchdog kills dlt-daemon. Add a timeout to these methods so that they may only run for as long as the watchdog timer is set. In addition, set the default WatchdogTimeout to an appropriate value in case the env variable is not set. Signed-off-by: Ahmet Findikci <ahmet.findikci@mercedes-benz.com>
lti9hc
reviewed
Jan 15, 2025
|
|
||
| if (watchdogTimeoutSeconds == 0) { | ||
| dlt_log(LOG_WARNING, "Watchdog timeout is too small, need at least 1s, setting 1s timeout\n"); | ||
| watchdogTimeoutSeconds = 1; |
There was a problem hiding this comment.
Should we set the default value is 30 for this case?
There was a problem hiding this comment.
we could, but this scenario only applies if WATCHDOG_USEC was deliberately set to 0, the default 30 is only used if the WATCHDOG_USEC is not set at all.
I have no opinion about it
There was a problem hiding this comment.
@lti9hc so do you want 30 or is 1 good for you?
lti9hc
reviewed
Jan 15, 2025
| return false; | ||
| } | ||
| if (sd_notify(0, "WATCHDOG=1") < 0) | ||
| dlt_vlog(LOG_WARNING, "%s: Could not reset systemd watchdog\n", __func__); |
There was a problem hiding this comment.
I think we should add return false in case could not reset the systemd watchdog
There was a problem hiding this comment.
yup, I can add that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods can take longer than the systemd watchdog timeout allowed, depending on the number of clients, which leads that the systemd watchdog kills dlt-daemon. Add a timeout to these methods so that they may only run for as long as the watchdog timer is set. In addition, set the default WatchdogTimeout to an appropriate value in case the env variable is not set.
The program was tested solely for our own use cases, which might differ from yours.
Licensed under Mozilla Public License Version 2.0
Ahmet Findikci ahmet.findikci@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, imprint