Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dlf file extension when saving filter #567

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

vifactor
Copy link
Collaborator

If user-typed filename does not have any extension.

This small UX improvement I decided to propose after spending some time to understand why "default filter functionality" does not work even though I placed the filter file into right folder. The cause was that I saved filter in a file without dlf-suffix

Signed-off-by: Viktor Kopp <vifactor@gmail.com>
@vifactor
Copy link
Collaborator Author

@alexmucde how would you want me to use the rights you granted to me? May I merge small PRs like this one which I am confident about?

@alexmucde
Copy link
Collaborator

@vifactor I would like to have a final look before merging, or even test the version if it is a bigger thing. But my time is limited, so i can have only a look from time to time.

@alexmucde alexmucde added this to the Release v2.27.0 milestone Oct 17, 2024
@alexmucde alexmucde merged commit 05d05cb into master Oct 17, 2024
4 checks passed
@vifactor
Copy link
Collaborator Author

makes sense, of course, I just wanted to clarify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants