-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types and datatypes #683
Comments
I was also perplexed by this since the current docs for
Relating to the above definition of It would be great to have the understanding confirmed/disconfirmed. If the above is correct I would like to understand the intended usage of the |
This PR intends align terms used in documentation * If we refer to a VSS data type, the term "datatype" is used * If we refer to the VSS node attribute "type" that specifies if a node is a branch, sensor, actuator, struct, ... we use the term "type" Fixes COVESA#683
@erikbosch thanks for #688 . Would you be able to comment on the specific question above about intended use of |
This PR intends align terms used in documentation * If we refer to a VSS data type, the term "datatype" is used * If we refer to the VSS node attribute "type" that specifies if a node is a branch, sensor, actuator, struct, ... we use the term "type" Fixes COVESA#683 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@jsyvanen - you can check som struct examples in vss-tools for testing, like the one in https://github.com/COVESA/vss-tools/blob/master/tests/vspec/test_structs/TestBranch1.vspec As of today
Would if represented in for example C++ be something like
I.e. the VSS properties correspond to C++ struct members. |
This PR intends align terms used in documentation * If we refer to a VSS data type, the term "datatype" is used * If we refer to the VSS node attribute "type" that specifies if a node is a branch, sensor, actuator, struct, ... we use the term "type" Fixes #683 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
This PR intends align terms used in documentation * If we refer to a VSS data type, the term "datatype" is used * If we refer to the VSS node attribute "type" that specifies if a node is a branch, sensor, actuator, struct, ... we use the term "type" Fixes COVESA#683 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
This PR intends align terms used in documentation * If we refer to a VSS data type, the term "datatype" is used * If we refer to the VSS node attribute "type" that specifies if a node is a branch, sensor, actuator, struct, ... we use the term "type" Fixes #683 Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
I would like to share my observations about VSS types and datatypes. The current classification is as follows:
I have two questions here:
First, the difference between types
attribute
andproperty
is unclear to me. Let me try to summarize my understanding below. Is that right?sensor
denotes a dynamic (temporal) signal not directly controllable by the system -- fast changeactuator
denotes a dynamic (temporal) signal directly controllable by the system -- fast changeattribute
denotes a dynamic? configuration variable -- thus, runtime-changeable but not often.property
denotes a static? configuration parameter? -- runtime-constantSecond, I understand that
struct
is a relatively new keyword for the VSS project. My initial assessment would place the structural elements ofstruct
andbranch
underdatatype
as I could not find a functional description forstruct
as above. The same is true forbranch
where the difference is that structs are packed, and branches are not. Therefore, what would say about the following classification that moves them under datatypes?Even more, taking full liberty to ignore all necessary backward compatibility issues (probably the project cannot do very easily), I would prefer the key
type
instead ofdatatype
for compatibility with other specification formats, mainly JSON Schema, and prefer another term, likekind
orclass
, to denote its usage in the system.And, a straightforward mapping to JSON types may be valuable as I would map
tuple
andlist
to JSON arrays as well asstruct
andbranch
to JSON objects. But I admit I don't have much prior experience with other formats that VSS can be converted.The text was updated successfully, but these errors were encountered: