Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change datatype for HVAC temeprature #637

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

SebastianSchildt
Copy link
Collaborator

It was defined as int, most cars are drive have 0.5°C steps to set temperature, which can not be mapped to the current VSS model.

Changing this to float in the model fixed it, and then it is up to an app/user to represent this with a lower granularity if requried.

…er than 1°C granualrity

Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
@SebastianSchildt
Copy link
Collaborator Author

Meeting Notes 8/23

@erikbosch
Copy link
Collaborator

I would say that a datatype change in most cases shall be considered as a backward incompatible changeIf a client use a signal with float type then it is reasonable that the server also handles it as a float type.

@erikbosch
Copy link
Collaborator

Meeting notes:

  • OK to merge from content perspective
  • Shall be for the next "major release", await merging until minor/major process clarified

@erikbosch
Copy link
Collaborator

Merging to master, shall not be included in 4.X (and this v4.1 release)

@erikbosch erikbosch merged commit 432f845 into COVESA:master Sep 15, 2023
3 checks passed
@erikbosch erikbosch deleted the fix/HVAC_temperature_set branch September 15, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants