Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screen mirroring in Infotainment.vspec #686

Closed
wants to merge 4 commits into from
Closed

Update screen mirroring in Infotainment.vspec #686

wants to merge 4 commits into from

Conversation

spshin3
Copy link
Contributor

@spshin3 spshin3 commented Nov 9, 2023

Add screen mirroring in infortainment.

Mirror phone screen to car screen.

Add screen mirroring in infortainment.

Mirror phone screen to car screen.
@erikbosch
Copy link
Collaborator

There i a build error and the commit is not signed off. Can be solved by amending you commit with a signoff with git commit --amend -s and then do a force push.

@erikbosch
Copy link
Collaborator

erikbosch commented Nov 14, 2023

Meeting notes:

  • Please review
  • What is the difference between "SmartphoneProjection" and "SmartphoneScreenMirroring". They share to a big degree the same signals. Or is the intention to rename that branch.

@erikbosch erikbosch added Status:Rework Committer must refactor or address comments Status:Review Please review/discuss contents labels Nov 21, 2023
spshin3 and others added 3 commits December 12, 2023 11:27
Resolving comment from erik
Signed-off-by: Sungpil Shin <spshin@etri.re.kr>
@spshin3
Copy link
Contributor Author

spshin3 commented Dec 13, 2023

To resolve a DCO issue, this commit will close and I will re-commit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Review Please review/discuss contents Status:Rework Committer must refactor or address comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants