Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Makefile for binary #720

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

erikbosch
Copy link
Collaborator

This is the last part of
COVESA/vss-tools#121

This is the last part of
COVESA/vss-tools#121

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch added Scope:Trivial Spelling fixes, submodule update, trivial bug-fixes, and similar. Status:New An issue/PR that not yet have been discussed/announced at a VSS meeting Status:Meeting Intended to be discussed at next VSS-project meeting labels Feb 13, 2024
@erikbosch
Copy link
Collaborator Author

MoM: Please review, especially @UlfBj

@UlfBj
Copy link
Contributor

UlfBj commented Feb 15, 2024

If the gcc command is remove from here it needs to be called elsewhere, e. g. in the vspec2binary.py.

@erikbosch
Copy link
Collaborator Author

If the gcc command is remove from here it needs to be called elsewhere, e. g. in the vspec2binary.py.

Yes, and that is what happens, as we call cd ${TOOLSDIR}/binary && $(MAKE). That means we enter vss-tools/binary directory and execute make there, which triggers gcc. See example below. So actual behavior shall be the same.

erik@debian4:~/vehicle_signal_specification$ make binary
cd ./vss-tools/binary && make
make[1]: Entering directory '/home/erik/vss-tools/binary'
rm -f binarytool.so
gcc -shared -o binarytool.so -fPIC binarytool.c
make[1]: Leaving directory '/home/erik/vss-tools/binary'
./vss-tools/vspec2binary.py --uuid -u ./spec/units.yaml ./spec/VehicleSignalSpecification.vspec vss_rel_$(cat VERSION).binary
INFO     Known extended attributes: 
INFO     Added 29 quantities from /home/erik/vehicle_signal_specification/spec/quantities.yaml
INFO     Added 61 units from ./spec/units.yaml
INFO     Loading vspec from ./spec/VehicleSignalSpecification.vspec...
INFO     Calling exporter...
INFO     Generating binary output...
INFO     Binary output generated in vss_rel_5.0-dev.binary
INFO     All done.

@UlfBj
Copy link
Contributor

UlfBj commented Feb 15, 2024

@erikbosch, thanks for the explanation. After understanding it I see no problem with this.

@erikbosch erikbosch removed the Status:New An issue/PR that not yet have been discussed/announced at a VSS meeting label Feb 20, 2024
@erikbosch erikbosch merged commit ecede6e into COVESA:master Feb 20, 2024
4 checks passed
@erikbosch erikbosch deleted the erik_makefile branch February 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope:Trivial Spelling fixes, submodule update, trivial bug-fixes, and similar. Status:Meeting Intended to be discussed at next VSS-project meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants