Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submodule update and CI extension #772

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Submodule update and CI extension #772

merged 1 commit into from
Sep 16, 2024

Conversation

erikbosch
Copy link
Collaborator

@erikbosch erikbosch commented Sep 10, 2024 •
edited
Loading

Adding support for new tools

@erikbosch
Copy link
Collaborator Author

Note that building ttl fails, but as it is an "optional tool" test passes anyway. Topics to discuss:

  • What to do with ttl, see vspec2ttl broken! vss-tools#403
  • How to treat the new ones (apigear and samm), optional OR mandatory. I am leaning towards treating them all as "mandatory", and deliberately "move" them to "optional" or "obsolete" when/if they fail
  • For the new ones - do we need any artifacts as part of release artifacts. If so how? They generate multiple files so if so zip them?

@erikbosch
Submodule update and CI extension
f5bcda3 
Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch marked this pull request as ready for review September 12, 2024 06:59
@erikbosch erikbosch mentioned this pull request Sep 12, 2024
Draft
SebastianSchildt
SebastianSchildt approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and is a good evolutionary step before thinking about changing anything about Makefiled and/or Actions

@erikbosch erikbosch added the Scope:Trivial Spelling fixes, submodule update, trivial bug-fixes, and similar. label Sep 16, 2024
@erikbosch erikbosch merged commit c45a5bd into COVESA:master Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchildt SebastianSchildt SebastianSchildt approved these changes

Assignees
No one assigned
Labels
Scope:Trivial Spelling fixes, submodule update, trivial bug-fixes, and similar.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @SebastianSchildt