Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Added is_instance to branch attributes #399

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

sschleemilch
Copy link
Collaborator

The info might be of interest to exporters and I think it makes sense to have that info in the internal tree

Related: COVESA/vehicle_signal_specification#749

Example:

Vehicle:
  type: branch
  description: Vehicle

Vehicle.Door:
  description: Door
  type: branch
  instances:
  - Row[1,2]

Vehicle.Door.Row1.Window:
  type: branch
  description: Window

vspec export tree -s test.vspec.yaml --attr is_instance:

Vehicle
is_instance=False
└── Door
    is_instance=False
    ├── Row1
    │   is_instance=True
    │   └── Window
    │       is_instance=False
    └── Row2
        is_instance=True

The info might be of interest to exporters.

Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
@erikbosch
Copy link
Collaborator

Should we possibly have a test case somewhere?

@sschleemilch
Copy link
Collaborator Author

Should we possibly have a test case somewhere?

Will do

Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
@sschleemilch
Copy link
Collaborator Author

Should we possibly have a test case somewhere?

Done

@erikbosch
Copy link
Collaborator

MoM:

  • Daniel presented the solution
  • Please review, possible merge decision next week

@erikbosch
Copy link
Collaborator

MoM:

  • Merge

@erikbosch erikbosch merged commit 97b6df8 into COVESA:master Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants