Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Refactored README, Installation, Contributing #400

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sschleemilch
Copy link
Collaborator

@sschleemilch sschleemilch commented Sep 4, 2024

@sschleemilch sschleemilch force-pushed the feature/docs-quickstart branch 4 times, most recently from 5e687e8 to 6b6df1c Compare September 5, 2024 04:26
@sschleemilch sschleemilch changed the title Refactored README, Installation, Contributing 🔨 Refactored README, Installation, Contributing Sep 5, 2024

There are several ways of installing `vss-tools`.
If you would like to contribute then please follow the [contribute](#contributing) section instead.
All of them are recommended to be done in an activated python virtual environment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have seen some people struggling to get a working Python environment I am thinking if we should give some more guidance here, either just add a link to venv documentation like "activated python virtual environment" or possibly also show an example how to do it, like in this README

https://github.com/eclipse-kuksa/kuksa-python-sdk/blob/main/docs/building.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added instructions how to create a venv

Signed-off-by: Sebastian Schleemilch <sebastian.schleemilch@bmw.de>
Copy link
Collaborator

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As this is a minor change I think we can take a merge decision on Tuesday unless someone wants more time to review.

@erikbosch erikbosch added the Scope:Minor A change that is not major and not trivial. label Sep 6, 2024
@erikbosch
Copy link
Collaborator

MoM:

  • Merge

@erikbosch erikbosch merged commit 9daa7a9 into COVESA:master Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope:Minor A change that is not major and not trivial.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants