Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing anytree dependency #408

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

erikbosch
Copy link
Collaborator

We have started to use 2.9 functionality
Latest is 2.12 but keeping 2.9 for maximum compatibility

Also updating poetry.lock by poetry.lock

@erikbosch
Copy link
Collaborator Author

FYI @sschleemilch @SebastianSchildt

If test works I will merge this for 5.0 and create a new rc. But we can discuss wanted approach for main, I see two main alternatives

  • Specifying minimum version that works, in this case 2.9
  • Specifying latest and greatest, i.e. what we committers actually use and what is used in CI, in this case 2.12

The latter approach gives less risk for problems as detected by @UlfBj (as we do not test older versions like 2.8/2.9 in CI), but might give more problems if you want to run other tools which does not support 2.12 in the same python env/venv.

@erikbosch erikbosch marked this pull request as ready for review October 3, 2024 11:21
We have started to use 2.9 functionality
Latest is 2.12 but keeping 2.9 for maximum compatibility

Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
@erikbosch erikbosch merged commit 9ba7f40 into COVESA:release/5.0 Oct 3, 2024
5 checks passed
@erikbosch erikbosch deleted the erik_5.0 branch October 3, 2024 12:07
@sschleemilch
Copy link
Collaborator

Good finding. We should think about pinning dependencies if we encounter something like that again

@erikbosch erikbosch mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants