Added the ability to have code based configuration rather than file based #103

stevechilds · 2016-09-27T15:55:31Z

In Addition logfiles now no longer have to exist, they are created upon first use.

…ased. Logfiles now no longer have to exist, they are created upon first use.

Peardian · 2016-09-27T21:03:46Z

Thank you for the contribution! I don't have time to fully check it just yet, but it looks like Travis already caught a small problem. Until I am able to test it, would you mind fixing the issue and any others that pop up in Travis?

stevechilds · 2016-09-27T21:07:27Z

No problem. I did run it through the tests, but not Travis, but it's about time I looked into Travis anyway :)

Regards

Steve

Peardian

I think I did this correctly

Peardian · 2016-09-27T20:58:14Z

includes/classes/AmazonCore.php

-            }
-            if (isset($logfunction) && $logfunction != '' && function_exists($logfunction)){
+            $logCallback = $this->config->getLogCallback();
+            if (empty($this->config->getLogCallback()) === false){


PHP 5.4 will give a fatal error on this

Peardian · 2016-09-27T21:08:33Z

CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).

+# 1.4.0 - 2016-08-27


If you don't mind, I would prefer it if changes to the changelog were handled by me at the time of release.

Peardian · 2016-09-27T21:17:20Z

CREDITS

@@ -1 +1,2 @@
 The phpAmazonMWS library was designed and written by Thomas Hernandez (peardian at gmail) for the CPI Group.
+The v1.4.0 refactoring when adding the AmazonMWSConfig class was done by Steve Childs (stevechilds76 at gmail) for Color Confidence (UK).


I do want to give contributors credit, but I haven't yet figured out the best way to go about it, so for now I would prefer it if the credits file was not modified. You are welcome to put an author tag in the new config class, though.

Peardian · 2016-09-27T21:25:37Z

Since the project has Travis support added, checking Travis is easy. All you have to do is click the red X (or green mark) next to the commit hash to see the test results.

stevechilds · 2016-09-27T21:27:02Z

They're all fine, I did wonder about the credits and change log, I just figured if you didn't want them, you'd revert them ;)

As for that bug, you're right, I missed that one it's obviously not covered by the tests, I'll fix that too when I'm back at work.

Regards

Steve

…ge log

stevechilds · 2016-09-28T08:17:35Z

Should hopefully all be fixed now :)

…t there was no logfile specified

Peardian · 2016-09-29T15:58:40Z

Thanks. I will get to checking it in-depth when I able to.

stevechilds · 2016-09-29T16:01:34Z

My pleasure @Peardian, thanks for creating the library in the first place, it's saved me a lot of time (even allowing for the half day to refactor the code ;) ).

When I've got some time I'll add some Symfony usage examples too, even if its just a 'how-to' for inclusion in the read-me, it may be useful to someone :)

ThomasRedstone · 2016-10-06T10:12:32Z

This is great, solves a real problem for me, is there any estimate on when it will be released @Peardian?

Peardian · 2016-10-06T13:59:48Z

@ThomasRedstone If I can't get to it next week, it may have to be sometime in November.

stevechilds · 2016-10-06T14:16:50Z

@ThomasRedstone - Feel free to use my fork (I think its public) in the mean time if you can't wait. I've been using it myself and I haven't found any issues yet... (Famous last words, I know!)

Peardian · 2016-10-27T19:10:40Z

I've finally had a chance to sit down and look through it in detail. It's good for the most part, but there are some tweaks I want to make to the design before it gets approved. When I have the time to work on it, I'll make pull request based off of your branch. I'll leave this open until then. Thanks again for the contribution!

Peardian · 2016-10-27T19:20:32Z

Drats, I should have known that the other pull request would conflict with this one. I'll fix them when I make my tweaks.

mpixelz · 2016-11-21T10:19:44Z

hi.. any chance this will be done anytime soon?

Peardian · 2016-11-21T14:52:33Z

I have been busy with other things in preparation for the holiday season. Once those are done, I may have time to work on this, but I can't make any guarantees until Christmas has passed.

stevechilds · 2016-12-13T12:09:00Z

Please Note, I've changed my username, so my fork is now at https://github.com/stevechilds/phpAmazonMWS

mpixelz · 2017-01-16T08:44:57Z

Hi,
just wanted to know when can we get this merged? :)
thanks.

Peardian · 2017-01-17T15:19:27Z

Unfortunately, I have not had a chance to work on this yet. I am still busy with wrapping up some holiday-time projects, but I may have some time to work on it at the end of the month or next month.

ahmettok · 2017-03-03T02:03:29Z

I think this is a great contribution to the project.
Any idea when you will merge?
I will use /stevechilds/phpAmazonMWS in the meantime.

Peardian · 2017-03-03T14:40:15Z

I don't have a solid answer, but I am hoping to work on it sometime this month. Only just last week was I able to finish up the projects I mentioned in my previous comment, so I hope to find time to work on this relatively soon.

ahmettok · 2017-03-07T01:11:30Z

Thank you, let me know if I can help with anything!

mpixelz · 2017-03-26T22:07:16Z

Hi @Peardian
hope you are doing good.. just wanted to ask whats an eta on this merge?
really looking forward on getting this merged :)
much appreciated on all the work you have already done :) saved me alot of time and effort :)
thanks.

Peardian · 2017-03-27T13:27:13Z

Unfortunately, I still haven't had a chance to work on this. I have been much busier than I anticipated with new projects. I want to work on this soon, though that is not entirely in my control. Maybe this summer I will have time.

Peardian · 2017-04-21T18:30:42Z

I finally have a bit of time to look into this. I don't think I'll be able to finish it today, but at the very least I can probably get a WIP pull request up.

Edit: I didn't get nearly as much time as I anticipated, and don't have anything presentable or functional yet. But rest assured, I have started tinkering with this.

mpixelz · 2017-04-25T14:16:39Z

Thanks @Peardian
your efforts are much appreciated! :)
looking forward.
cheers

Peardian · 2017-05-23T22:26:37Z

I am still continuing to look into this with the free time I can manage, though I don't think it will be part of the v1.4. I want to get support for new operations and fields in a stable release as soon as possible, and then this config overhaul can be part of v1.5.

JonLaliberte · 2017-06-06T13:56:10Z

Thanks again for all the work. Definitely looking forward to the config change being merged. Currently having to use the forked version for a few projects and would rather get back on the mainline. Again though, thanks for all the work, it makes working with MWS much more pleasant.

dustinmoore · 2018-02-26T15:39:10Z

Is there any ETA on this ever getting merged? I think using the forked version would potentially not be up to date with the most recent changes to Amazons API as compared to the master branch?

Peardian · 2018-02-26T16:00:10Z

Unfortunately, I have been quite busy and have not had a chance to work on this more. I can't make any promises on when it will be ready, but I plan for this to be the focus of the next release. I realize that it has been over a year now, and I apologize to everyone who has been patiently waiting on this feature.

cgsmith · 2019-02-05T04:12:45Z

ETA on getting this merged?

Peardian · 2019-02-05T15:30:09Z

Sadly, I haven't had a chance to work on this in over two years. Too many important projects taking up my time. I still intend to get to it eventually.

mrvnklm · 2019-02-05T18:05:13Z

For all of you looking for some solution: I use rapidwebltd/amazon-mws-config-generator to use the bundle with symfony.
You have the ability to generate config files on the fly so handling multiple users is not a problem anymore, so at least it's a temporary problem solving solution.

Added the ability to have code based configuration rather than file b…

45dd710

…ased. Logfiles now no longer have to exist, they are created upon first use.

stevechilds mentioned this pull request Sep 27, 2016

Pass MWS keys without config file #97

Open

Peardian requested changes Sep 27, 2016

View reviewed changes

Fixed error in the log function, reverted changes to Credits and Chan…

f0f9e6d

…ge log

Fixed minor error in Core that would occur if logging was enabled, bu…

dbc417f

…t there was no logfile specified

Peardian approved these changes Sep 29, 2016

View reviewed changes

Peardian added the enhancement label Sep 29, 2016

Peardian changed the base branch from stable to master November 3, 2016 15:32

Peardian mentioned this pull request Dec 13, 2016

store serviceURL append final slash #109

Open

		@@ -1 +1,2 @@
		The phpAmazonMWS library was designed and written by Thomas Hernandez (peardian at gmail) for the CPI Group.
		The v1.4.0 refactoring when adding the AmazonMWSConfig class was done by Steve Childs (stevechilds76 at gmail) for Color Confidence (UK).

Added the ability to have code based configuration rather than file based #103

Are you sure you want to change the base?

Added the ability to have code based configuration rather than file based #103

Conversation

stevechilds commented Sep 27, 2016

Peardian commented Sep 27, 2016

stevechilds commented Sep 27, 2016 • edited by Peardian Loading

Peardian left a comment

Choose a reason for hiding this comment

Peardian Sep 27, 2016

Choose a reason for hiding this comment

Peardian Sep 27, 2016

Choose a reason for hiding this comment

Peardian Sep 27, 2016

Choose a reason for hiding this comment

Peardian commented Sep 27, 2016

stevechilds commented Sep 27, 2016 • edited by Peardian Loading

stevechilds commented Sep 28, 2016

Peardian commented Sep 29, 2016

stevechilds commented Sep 29, 2016 • edited Loading

ThomasRedstone commented Oct 6, 2016

Peardian commented Oct 6, 2016

stevechilds commented Oct 6, 2016

Peardian commented Oct 27, 2016

Peardian commented Oct 27, 2016

mpixelz commented Nov 21, 2016

Peardian commented Nov 21, 2016

stevechilds commented Dec 13, 2016

mpixelz commented Jan 16, 2017

Peardian commented Jan 17, 2017

ahmettok commented Mar 3, 2017

Peardian commented Mar 3, 2017

ahmettok commented Mar 7, 2017

mpixelz commented Mar 26, 2017

Peardian commented Mar 27, 2017

Peardian commented Apr 21, 2017 • edited Loading

mpixelz commented Apr 25, 2017

Peardian commented May 23, 2017 • edited Loading

JonLaliberte commented Jun 6, 2017

dustinmoore commented Feb 26, 2018

Peardian commented Feb 26, 2018

cgsmith commented Feb 5, 2019

Peardian commented Feb 5, 2019

mrvnklm commented Feb 5, 2019 • edited Loading

stevechilds commented Sep 27, 2016 •

edited by Peardian

Loading

stevechilds commented Sep 27, 2016 •

edited by Peardian

Loading

stevechilds commented Sep 29, 2016 •

edited

Loading

Peardian commented Apr 21, 2017 •

edited

Loading

Peardian commented May 23, 2017 •

edited

Loading

mrvnklm commented Feb 5, 2019 •

edited

Loading