[BUGFIX] Convert non-list arrays in API response #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
force-pushed
the
fix/xml-mapping
branch
from
17f8027
to
a236656
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit be5624b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 12.2% (12.2% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## develop #85 +/- ##
==============================================
+ Coverage 0.00% 12.23% +12.23%
- Complexity 222 241 +19
==============================================
Files 28 32 +4
Lines 721 793 +72
==============================================
+ Hits 0 97 +97
+ Misses 721 696 -25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eliashaeussler
force-pushed
the
fix/xml-mapping
branch
from
a236656
to
3282615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue if converted API responses differ from the expected array structure used to parse and map responses to objects. This may happen if only one position is included in the response or if only one job description is included.
With this PR, an appropriate mapper source is introduced which converts those array paths to lists, ensuring a clean array structure.
Resolves: #81