Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document process on how to enable/disable plugins with the opensearch_dashboards.yml config file #6

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

manasvinibs
Copy link
Contributor

Signed-off-by: manasvinibs manasvis@amazon.com

Signed-off-by: manasvinibs <manasvis@amazon.com>
@ashwin-pc
Copy link

Probably rename this to be how to enable and disable plugins with the config file. This does not apply to any config setting after all

Copy link
Contributor

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I learned a lot!

A couple of formatting suggestions and extra info, but feel free to accept or ignore as you wish!

@@ -0,0 +1,49 @@
# Add new config to the {root}/config/opensearch-dashboards.yml file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add new config to the {root}/config/opensearch-dashboards.yml file
# Add new config to the `{root}/config/opensearch-dashboards.yml` file

@@ -0,0 +1,49 @@
# Add new config to the {root}/config/opensearch-dashboards.yml file

1. Add new config value in the opensearch_dashboards.yml file. Below is an example where I'm adding new flag to hide/show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Add new config value in the opensearch_dashboards.yml file. Below is an example where I'm adding new flag to hide/show
1. Add a commented out new config value in the `opensearch_dashboards.yml` file. Below is an example where I'm adding new flag to hide/show

# wizard.enabled: true
```

Note that the yml config values are read as path to the plugin config schema file. In the above example, `wizard` is the `Id` of the plugin to which I'm introducing this new config value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that the yml config values are read as path to the plugin config schema file. In the above example, `wizard` is the `Id` of the plugin to which I'm introducing this new config value.
Note that the yml config values are read as path to the plugin config schema file. In the above example, `wizard` is the `Id` of the plugin to which I'm introducing this new config value. The value should match the default, so that if a user uncomments the line, it will still have the default behavior.

};

```
We need to set `exposeToBrowser` true for the config property `enabled` which we have defined in the config schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pure speculation, but my guess is that you can use the config in server components even without that setting, but it's necessary for it to be available to public components and services.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. exposeToBrowser will allow the components in the public folder to get that value but is still usable in the server.

@CPTNB CPTNB merged commit b16a325 into CPTNB:main Jul 27, 2022
@manasvinibs manasvinibs changed the title Document process to add new config for opensearch_dashboards.yml Document process on how to enable/disable plugins with the opensearch_dashboards.yml config file Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants