Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return already-compiled hugrs from GuppyModule.compile #247

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

aborgna-q
Copy link
Collaborator

Closes #246

I'm not sure where to add a test for this, as it's not integration nor error testing.

@aborgna-q aborgna-q requested a review from mark-koch June 18, 2024 09:44
@mark-koch
Copy link
Collaborator

I'm not sure where to add a test for this, as it's not integration nor error testing.

Mhm it's probably fine to just add it to the integration module, maybe in a new file or in test_basic.py?

@aborgna-q aborgna-q merged commit 9d01eae into main Jun 18, 2024
3 checks passed
@aborgna-q aborgna-q deleted the ab/keep-module-hugr branch June 18, 2024 11:34
github-merge-queue bot pushed a commit that referenced this pull request Jul 2, 2024
🤖 I have created a release *beep* *boop*
---


## [0.6.0](v0.5.2...v0.6.0)
(2024-07-02)


### Features

* Add array type ([#258](#258))
([041c621](041c621))
* Add nat type ([#254](#254))
([a461a9d](a461a9d))
* Add result function
([#271](#271))
([792fb87](792fb87)),
closes [#270](#270)
* Allow constant nats as type args
([#255](#255))
([d706735](d706735))
* Generate constructor methods for structs
([#262](#262))
([f68d0af](f68d0af)),
closes [#261](#261)
* Return already-compiled hugrs from `GuppyModule.compile`
([#247](#247))
([9d01eae](9d01eae))
* Turn int and float into core types
([#225](#225))
([99217dc](99217dc))


### Bug Fixes

* Add missing test file
([#266](#266))
([75231fe](75231fe))
* Loading custom polymorphic function defs as values
([#260](#260))
([d15b2f5](d15b2f5)),
closes [#259](#259)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep the Hugr around after compiling a module
2 participants