feat: Allow constant nats as type args #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Craig Roy <croyzor@users.noreply.github.com>
mark-koch
commented
Jun 20, 2024
Comment on lines
+3
to
+6
| 7: @guppy(module) | ||
| 8: def main(x: array[int, bool]) -> None: | ||
| ^^^^^^^^^^^^^^^^ | ||
| GuppyTypeError: Expected argument of type `nat`, got type |
There was a problem hiding this comment.
The unspecific error location is expected, a bigger refactor is required to track the source locations of type args
ss2165
approved these changes
Jun 20, 2024
guppylang/tys/ty.py
Outdated
| """Helper function for unification of type variables.""" | ||
| def _unify_var(var: ExistentialVar, t: Type | Const, subst: "Subst") -> "Subst | None": | ||
| """Helper function for unification of type or const variables.""" | ||
| assert isinstance(var, ExistentialTypeVar | ExistentialConstVar) |
There was a problem hiding this comment.
seems odd for this to not be the type annotation, some subtype vs union shenanigans?
| @@ -94,6 +94,9 @@ def arg_from_ast( | |||
| # right now. | |||
| # TODO: Once we also have int args etc, we need proper inference logic here | |||
| if isinstance(node, ast.Constant) and isinstance(node.value, int): | |||
| # Fun fact: int ast.Constant values are never negative since e.g. `-5` is a | |||
mark-koch
force-pushed
the
feat/nats
branch
2 times, most recently
from
0d37aef to
b664d2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 90.90% 90.67% -0.24%
==========================================
Files 44 44
Lines 4839 4954 +115
==========================================
+ Hits 4399 4492 +93
- Misses 440 462 +22 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.2...v0.6.0) (2024-07-02) ### Features * Add array type ([#258](#258)) ([041c621](041c621)) * Add nat type ([#254](#254)) ([a461a9d](a461a9d)) * Add result function ([#271](#271)) ([792fb87](792fb87)), closes [#270](#270) * Allow constant nats as type args ([#255](#255)) ([d706735](d706735)) * Generate constructor methods for structs ([#262](#262)) ([f68d0af](f68d0af)), closes [#261](#261) * Return already-compiled hugrs from `GuppyModule.compile` ([#247](#247)) ([9d01eae](9d01eae)) * Turn int and float into core types ([#225](#225)) ([99217dc](99217dc)) ### Bug Fixes * Add missing test file ([#266](#266)) ([75231fe](75231fe)) * Loading custom polymorphic function defs as values ([#260](#260)) ([d15b2f5](d15b2f5)), closes [#259](#259) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing commit by commit
Closes #214