Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linearity checking bug #354

Closed
mark-koch opened this issue Jul 31, 2024 · 0 comments · Fixed by #355
Closed

Linearity checking bug #354

mark-koch opened this issue Jul 31, 2024 · 0 comments · Fixed by #355
Assignees
@mark-koch
Labels
bug Something isn't working

Comments

@mark-koch
Copy link
Collaborator

The following program passes the linearity checker even though it shouldn't!

@guppy(module)
def test(n: int) -> None:
    q = qubit()
    i = 0
    while i < n:
        q = h(q)
        i += 1

This bug was introduced in #273. Very annoying that we didn't catch this earlier with a test
@mark-koch mark-koch added the bug Something isn't working label Jul 31, 2024
@mark-koch mark-koch self-assigned this Jul 31, 2024
@mark-koch mark-koch changed the title Liniearity checking bug Linearity checking bug Jul 31, 2024
@mark-koch mark-koch mentioned this issue Jul 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 31, 2024
@mark-koch
fix: Linearity checking bug (#355)
e14660f 
Fixes #354.

When checking for unused linear variables, we should look at *all*
variables in scope, not only the ones that were defined in the current
BB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Linearity checking bug CQCL/guppylang
1 participant
@mark-koch