Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement imports w/o linking #425

Closed
Tracked by #424
mark-koch opened this issue Aug 29, 2024 · 0 comments · Fixed by #432
Closed
Tracked by #424

Implement imports w/o linking #425

mark-koch opened this issue Aug 29, 2024 · 0 comments · Fixed by #432
Assignees

Comments

@mark-koch
Copy link
Collaborator

Just lower everything into the same Hugr until we have implemented proper Hugr linking

@mark-koch mark-koch self-assigned this Aug 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 2, 2024
Closes #425 and closes #427 and closes #134

* Allow importing of function definitions (before we could only import
declarations)
* Until we have Hugr linking, we just lower everything into the same
Hugr. This requires some changes to the compilation logic:
- Differentiate between checking (`module.check()`) and full Hugr
compilation (`module.compile()`) of modules
  - Importing modules only checks them
- Hugr lowering is done at the end in one step over all imported modules
* Allow to import individual definitions instead of whole modules
* Allow aliased imports using kwargs (see test examples)
@mark-koch mark-koch added this to the guppylang 0.10.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant