feat!: Use angle type in quantum operations #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
force-pushed
the
feat/quantum-angles
branch
from
210e0ba to
da8e2d9
Compare
mark-koch
force-pushed
the
feat/quantum-angles
branch
from
da8e2d9 to
7669a6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 91.94% 91.98% +0.03%
==========================================
Files 58 58
Lines 5849 5852 +3
==========================================
+ Hits 5378 5383 +5
+ Misses 471 469 -2 ☔ View full report in Codecov by Sentry. |
ss2165
reviewed
Sep 9, 2024
| @@ -68,10 +70,10 @@ def random_walk_phase_estimation( | |||
| def example_controlled_oracle(q1: qubit, q2: qubit, t: float) -> tuple[qubit, qubit]: | |||
There was a problem hiding this comment.
should this function take an angle?
There was a problem hiding this comment.
Depends how you interpret things. I always think of the t in e^(-itH) as time so I kept float here. But happy to change the angle if you prefer (will require more explicit angle to float and vice versa conversions though)
ss2165
approved these changes
Sep 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.10.0...v0.11.0) (2024-09-11) ### ⚠ BREAKING CHANGES * `guppy.take_module` renamed to `guppy.get_module` and no longer removes the module from the state. * Quantum operations `rx`, `rz`, `phased_x`, and `zz_max` use the `angle` type instead of floats. ### Features * Add implicit importing of modules ([#461](#461)) ([1b73032](1b73032)) * Use angle type in quantum operations ([#467](#467)) ([ce0f746](ce0f746)) ### Bug Fixes * hseries ops use floats instead of angles ([#483](#483)) ([7ed3853](7ed3853)), closes [#477](#477) * Keep track of definitions that are implicitly imported ([#481](#481)) ([a89f225](a89f225)), closes [#480](#480) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
BREAKING CHANGE: Quantum operations
rx,rz,phased_x, andzz_maxuse theangletype instead of floats.