Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep track of definitions that are implicitly imported #481

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mark-koch
Copy link
Collaborator

Fixes #480

@mark-koch mark-koch requested a review from aborgna-q September 11, 2024 13:52
@mark-koch mark-koch requested a review from a team as a code owner September 11, 2024 13:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (1b73032) to head (eaceb66).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   92.00%   91.99%   -0.01%     
==========================================
  Files          58       58              
  Lines        5900     5898       -2     
==========================================
- Hits         5428     5426       -2     
  Misses        472      472              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mark-koch mark-koch added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit a89f225 Sep 11, 2024
3 checks passed
@mark-koch mark-koch deleted the fix/private-imports branch September 11, 2024 14:22
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


## [0.11.0](v0.10.0...v0.11.0)
(2024-09-11)


### ⚠ BREAKING CHANGES

* `guppy.take_module` renamed to `guppy.get_module` and no longer
removes the module from the state.
* Quantum operations `rx`, `rz`, `phased_x`, and `zz_max` use the
`angle` type instead of floats.

### Features

* Add implicit importing of modules
([#461](#461))
([1b73032](1b73032))
* Use angle type in quantum operations
([#467](#467))
([ce0f746](ce0f746))


### Bug Fixes

* hseries ops use floats instead of angles
([#483](#483))
([7ed3853](7ed3853)),
closes [#477](#477)
* Keep track of definitions that are implicitly imported
([#481](#481))
([a89f225](a89f225)),
closes [#480](#480)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error when calling imported fns that call private functions
3 participants