-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Use the hugr builder #366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/hugr-builder
branch
from
August 8, 2024 10:26
62fb6a3
to
cbe3c25
Compare
aborgna-q
force-pushed
the
ab/hugr-builder
branch
from
August 8, 2024 13:29
991dc70
to
7cba3b4
Compare
aborgna-q
force-pushed
the
ab/hugr-builder
branch
from
August 12, 2024 11:09
d53c812
to
b9acbd1
Compare
Co-authored-by: Mark Koch <48097969+mark-koch@users.noreply.github.com>
mark-koch
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I think this is ready to be merged! I'm happy with your builtins solution, way nicer than before.
aborgna-q
added a commit
that referenced
this pull request
Sep 10, 2024
This commit will probably get overwritten by a release-please update. The COMMIT_OVERRIDE in #366 should be the permanent fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an in-progress transplant of guppy from using an ad-hoc
Hugr
definition into the builder from thehugr
library.The main mismatch between the old and new builders is that guppy used to lazily add typed ports to the graph nodes as it needed. Since the new builder requires operations to define their signature, we end up having to edit the code everywhere from
guppylang.compiler
to theguppylang.prelude
definitions.My first goal is to get this working, and then I will try and split some changes from this PR (although most of it will have to be merged monolithically).
Current test status:
These issues currently breake some tests. I'll fix them before merging the PR
hugr-py
hugr#1319Required to store the module names in the hugr metadataRequired for pytket and llvm integrationRelease hugr and tket2 with the latest changesCloses #257. Closes #85
BREAKING CHANGE: Removed
guppylang.hugr_builder.hugr.Hugr
, compiling a module returns ahugr.ext.Package
instead. Usemodule.compile_hugr
to obtain ahugr.Hugr
.BEGIN_COMMIT_OVERRIDE
feat!: Use the hugr builder
BREAKING CHANGE: Removed
guppylang.hugr_builder.hugr.Hugr
, compiling a module returns ahugr.Package
instead.END_COMMIT_OVERRIDE