feat: Update linearity checker to use new diagnostics #601

mark-koch · 2024-10-29T10:24:17Z

Closes #541

mark-koch · 2024-10-29T10:28:37Z

tests/error/comprehension_errors/capture2.err

+   |                                  ^ Variable `q` with linear type `qubit` would be consumed
+   |                                    multiple times when
+   |                                    evaluating this
+   |                                    comprehension


This is a formatting bug. See #602

mark-koch · 2024-10-29T10:36:41Z

guppylang/checker/stmt_checker.py

-        node.value, ty = self._synth_expr(node.value)
-        if ty.linear:
-            raise GuppyTypeError(f"Value with linear type `{ty}` is not used", node)
+        node.value, _ = self._synth_expr(node.value)


Drive by: This error should be handled during linearity checking

codecov-commenter · 2024-10-29T10:43:54Z

Codecov Report

Attention: Patch coverage is 98.73016% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.03%. Comparing base (e096c53) to head (9bbfe75).
Report is 1 commits behind head on feat/diagnostics.

Files with missing lines	Patch %	Lines
guppylang/checker/core.py	77.77%	2 Missing ⚠️
guppylang/checker/linearity_checker.py	98.56%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##           feat/diagnostics     #601      +/-   ##
====================================================
+ Coverage             91.74%   92.03%   +0.29%     
====================================================
  Files                    61       62       +1     
  Lines                  6624     6832     +208     
====================================================
+ Hits                   6077     6288     +211     
+ Misses                  547      544       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ss2165

very nice, just some small queries

ss2165 · 2024-10-29T15:56:49Z

guppylang/checker/errors/linearity.py

+        "..."
+    )
+    place: Place
+    kind: "UseKind"


nit: from __future__ import annotations?

ss2165 · 2024-10-30T11:12:33Z

guppylang/checker/errors/linearity.py

+        if self.is_call_arg:
+            f = f"Function `{self.func_name}`" if self.func_name else "Function"
+            return (
+                f"{f} wants to take ownership of this argument, but you don't own "


Not a fan of "you" here, maybe be more specific about the calling scope?

ss2165 · 2024-10-30T11:48:17Z

guppylang/checker/linearity_checker.py

+    #: Ownership of an owned value is transferred by returning it
+    RETURN = auto()
+
+    #: An owned value is renamed or stored in a tuple/list


is tuple the same as struct here?

Unfortunately not since constructing a struct is a function call, so this counts as consumption

ss2165 · 2024-10-30T15:37:08Z

tests/error/comprehension_errors/guarded2.err

+   | 
+16 | @guppy(module)
+17 | def foo(qs: list[tuple[bool, qubit]] @owned) -> list[int]:
+18 |     return [42 for b, q in qs if b if bar(q)]


does python allow chained ifs? expected an and

Yep, that works in Python

We don't support and and or in comprehensions yet since we compile them to dataflow...

ss2165 · 2024-10-30T15:40:42Z

tests/error/comprehension_errors/used_twice1.err

+   |                 ^ Variable `q` with linear type `qubit` cannot be moved ...
+   | 
+13 |     return [(q, q) for q in qs]
+   |              - since it was already moved here


ss2165 · 2024-10-30T15:42:09Z

tests/error/inout_errors/already_used.err

+   |           ...
+   | 
+20 |     use(q)
+   |         - since it was already consumed here


"consumed" meaning enters another scope, and "moved" meaning belonging to a new name within same scope?

ss2165 · 2024-10-30T15:47:11Z

tests/error/linear_errors/field_copy1.err

+20 |     return s.q, t.q
+   |            ^^^ Field `s.q` with linear type `qubit` cannot be returned ...
+   | 
+19 |     t = s


i find it hard to read messages where the same line is repeated, once in the original and then once in the sub. Just a note, don't think there is anything to be done.

Yeah, the rendering can definitely be improved further. See #608

ss2165

This is the development branch for our new diagnostics infrastructure. Tracked by #535. * #548 * #551 * #552 * #553 * #586 * #588 * #587 * #589 * #590 * #600 * #601 * #604 * #605 * #606

🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.2...v0.13.0) (2024-11-12) ### ⚠ BREAKING CHANGES * `prelude` module renamed to `std` ### Features * add `qubit` discard/measure methods ([#580](#580)) ([242fa44](242fa44)) * Add `SizedIter` wrapper type ([#611](#611)) ([2e9da6b](2e9da6b)) * conventional results post processing ([#593](#593)) ([db96224](db96224)) * Improve compiler diagnostics ([#547](#547)) ([90d465d](90d465d)), closes [#551](#551) [#553](#553) [#586](#586) [#588](#588) [#587](#587) [#590](#590) [#600](#600) [#601](#601) [#606](#606) * restrict result tag sizes to 256 bytes ([#596](#596)) ([4e8e00f](4e8e00f)), closes [#595](#595) ### Bug Fixes * Mock guppy decorator during sphinx builds ([#622](#622)) ([1cccc04](1cccc04)) ### Documentation * Add DEVELOPMENT.md ([#584](#584)) ([1d29d39](1d29d39)) * Fix docs build ([#639](#639)) ([bd6011c](bd6011c)) ### Miscellaneous Chores * Manually set last release commit ([#643](#643)) ([b2d569b](b2d569b)) ### Code Refactoring * rename prelude to std ([#642](#642)) ([1a68e8e](1a68e8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>

mark-koch added 2 commits October 29, 2024 10:18

feat: Allow sub-diagnostic labels to refer to fields of their parent

5b9e985

feat: Update linearity checker to use new diagnostics

ebd74b1

mark-koch requested a review from ss2165 October 29, 2024 10:24

mark-koch requested a review from a team as a code owner October 29, 2024 10:24

mark-koch commented Oct 29, 2024

View reviewed changes

Fix BorrowSubPlaceUsedError message

9bb2b72

mark-koch commented Oct 29, 2024

View reviewed changes

Base automatically changed from diag/parent-format to feat/diagnostics October 29, 2024 10:38

Update notebook

9d71aba

mark-koch mentioned this pull request Oct 29, 2024

feat: Improve compiler diagnostics #547

Merged

ss2165 reviewed Oct 30, 2024

View reviewed changes

mark-koch added 2 commits October 31, 2024 11:57

Fix mood

e61b2d4

Use __future__ annotations

fc911e1

mark-koch mentioned this pull request Oct 31, 2024

Improve diagnostics rendering #608

Open

mark-koch added 2 commits October 31, 2024 12:17

Use function name instead of "you" in messages

44fabc0

Lints

9bbfe75

mark-koch requested a review from ss2165 October 31, 2024 12:19

ss2165 approved these changes Oct 31, 2024

View reviewed changes

mark-koch merged commit bdc6568 into feat/diagnostics Oct 31, 2024
2 checks passed

mark-koch deleted the diag/linearity branch October 31, 2024 13:08

mark-koch mentioned this pull request Oct 31, 2024

Update linearity checker to use new diagnostics #541

Closed

hugrbot mentioned this pull request Nov 11, 2024

chore(main): release 0.13.0 #518

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update linearity checker to use new diagnostics #601

feat: Update linearity checker to use new diagnostics #601

mark-koch commented Oct 29, 2024

mark-koch Oct 29, 2024

mark-koch Oct 29, 2024

codecov-commenter commented Oct 29, 2024 •

edited

Loading

ss2165 left a comment

ss2165 Oct 29, 2024

ss2165 Oct 30, 2024

ss2165 Oct 30, 2024

mark-koch Oct 31, 2024

ss2165 Oct 30, 2024

mark-koch Oct 31, 2024

ss2165 Oct 30, 2024

ss2165 Oct 30, 2024

mark-koch Oct 31, 2024

ss2165 Oct 30, 2024

mark-koch Oct 31, 2024

ss2165 left a comment

feat: Update linearity checker to use new diagnostics #601

feat: Update linearity checker to use new diagnostics #601

Conversation

mark-koch commented Oct 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 29, 2024 • edited Loading

Codecov Report

ss2165 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ss2165 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 29, 2024 •

edited

Loading