feat: Linearity check array comprehensions #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/array-compr #615 +/- ##
====================================================
+ Coverage 91.55% 91.70% +0.15%
====================================================
Files 60 60
Lines 6463 6497 +34
====================================================
+ Hits 5917 5958 +41
+ Misses 546 539 -7 ☔ View full report in Codecov by Sentry. |
doug-q
reviewed
Nov 11, 2024
| @@ -356,11 +360,11 @@ def _check_assign_targets(self, targets: list[ast.expr]) -> None: | |||
| self.scope.assign(tgt_place) | |||
|
|
|||
| def _check_comprehension( | |||
| self, node: DesugaredListComp, gens: list[DesugaredGenerator] | |||
| self, node: ast.expr, gens: list[DesugaredGenerator], elt: ast.expr | |||
There was a problem hiding this comment.
It looks like node is unused?
doug-q
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the list comprehension logic so we can also use it for array comprehensions