Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec regarding "Package" behaviour #1388

Open
ss2165 opened this issue Aug 1, 2024 · 1 comment
Open

Update spec regarding "Package" behaviour #1388

ss2165 opened this issue Aug 1, 2024 · 1 comment

Comments

@ss2165
Copy link
Member

ss2165 commented Aug 1, 2024

follow up from #1358

Specification needs to be updated to describe what a package is and how it can be well-formed (valid)

@aborgna-q
Copy link
Collaborator

aborgna-q commented Sep 13, 2024

Regarding the packed extensions, we should define that prelude and the std extensions do not need to be included.

The std extensions are listed on the spec. (A bit late for this, but it'd have been nice if the extension names started with std.)

github-merge-queue bot pushed a commit that referenced this issue Oct 21, 2024
Followup to #1587.

Ensures that rust `Package`s only contain module-rooted hugrs. Returns
errors at construction times if the condition is not met.
This required fixing `hugr-cli`, as it should be able to load both
packages and arbitrary hugrs.
Added `Package::from_hugr{,s}` methods that try to wrap the hugrs if
possible. We'll need these for tket2.

Packages are not on the spec yet, their description should include this
restriction. See #1388.

This PR does only modify the (unpublished) API introduced in #1587, so
I'm not marking it as breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants