You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On reflection this is not entirely true. We consider all incoming edges of a needed node to come from needed nodes. So a FuncDefn/Decl is needed if it's called by a needed node.
The issue is that "main" (or more generally, public functions) are not considered needed.
Constant folding already special cases the inputs of "main", we should at least special case that "main" is needed.
The text was updated successfully, but these errors were encountered:
Is it worth generalizing this to "establish a convention/API for indicating the entry-points to a Hugr" i.e. not just for constant folding but generally? (DCE/DeadFuncElim, etc. etc.) - see also #1752
In
find_needed_nodes
On reflection this is not entirely true. We consider all incoming edges of a needed node to come from needed nodes. So a FuncDefn/Decl is needed if it's called by a needed node.
The issue is that "main" (or more generally, public functions) are not considered needed.
Constant folding already special cases the inputs of "main", we should at least special case that "main" is needed.
The text was updated successfully, but these errors were encountered: