Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to validate a TypeParam #624

Closed
acl-cqc opened this issue Oct 25, 2023 · 2 comments
Closed

Add function to validate a TypeParam #624

acl-cqc opened this issue Oct 25, 2023 · 2 comments

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Oct 25, 2023

The significant check is probably only at the leaves, specifically TypeParam::Opaques, but we should check somewhere that we don't have an Opaque with a malformed CustomType like List<5> or similar (i.e., should be List<SomeType>)
acl-cqc added a commit that referenced this issue Oct 25, 2023
@acl-cqc
Remove TODO about validating a TypeParam, raised #624
a9bc987
@acl-cqc acl-cqc mentioned this issue Oct 25, 2023
Closed
@ss2165
Copy link
Member

ss2165 commented Jul 24, 2024

Can we close this as of #1328?

@acl-cqc
Copy link
Contributor Author

acl-cqc commented Jul 26, 2024

Yes good spot! I don't see anything in any of the other "leaves" or elsewhere to validate.

@acl-cqc acl-cqc closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ss2165 @acl-cqc