Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panic to prelude and clarify operation panicking method #746

Closed
ss2165 opened this issue Dec 15, 2023 · 0 comments · Fixed by #801
Closed

Add panic to prelude and clarify operation panicking method #746

ss2165 opened this issue Dec 15, 2023 · 0 comments · Fixed by #801
Assignees
@ss2165
Labels
spec Issues to do with the specification document(s)
Milestone
v0.1.0

Comments

@ss2165
Copy link
Member

ss2165 commented Dec 15, 2023

Blocked by/could be part of #737

The spec mentions the panic operation:

hugr/specification/hugr.md

Line 1551 in bd0dcbe

`panic`: panics unconditionally; no inputs, any type of outputs (these

but also talks about how operations may panic internally, returning some error type:

hugr/specification/hugr.md

Lines 704 to 708 in bd0dcbe

#### `ErrorType`
- There is some type of errors, perhaps just a string, or
`Tuple(USize,String)` with some errorcode, that is returned along with
the fact that the graph/program panicked.

The relationship between the two modes should be clarified.

Perhaps panic takes an ErrorType input?
@ss2165 ss2165 added the spec Issues to do with the specification document(s) label Dec 15, 2023
@ss2165 ss2165 added this to the v0.1.0 milestone Jan 4, 2024
@ss2165 ss2165 mentioned this issue Jan 9, 2024
Merged
4 tasks
@ss2165 ss2165 self-assigned this Jan 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2024
@ss2165 @acl-cqc
docs: collection of spec updates for 0.1 (#801)
b7c9c7c 
- [x] Closes #744 
- [x] Closes #747 
- [x] Closes #737 
- [x] Closes #746

---------

Co-authored-by: Alan Lawrence <alan.lawrence@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
spec Issues to do with the specification document(s)
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

docs: collection of spec updates for 0.1 CQCL/hugr
1 participant
@ss2165