feat!: replace opaque type arguments with String #1328
Merged
Commits on Jul 24, 2024
-
feat!: opaque type arguments are untyped bytes.
Closes #1308 - Previously held a yaml value, this doesn't really make much sense - If it is an opaque blob, no reason it needs a HUGR custom type attached to it? - Now truly opaque, it is up to extension-aware tooling to use the bytes data as they see fit - Serialised as base64 encoded string - Utilities for common case, strings - Conducive with adding typed "operation intrinsics/properties" as a follow-up. This would be hugr-typed values that can be attached to operations (in a semantically significant manner, unlike metadata) but perhaps are not allowed to affect the signature. - should there be a cap on size of byte array? If so should we use `[u8; N]` over `Vec<u8>`? - Serialisation break to be handled TODO BREAKING_CHANGE: opaque type arguments are now untyped and hold bytes rather than a yaml value. Serialised form is base64 string.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.