fix: dfg wrapper build handles incorrect output wire numbers #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFGWrapper handles incorrectly were using internal dfg output number as the outputs from the container node. Fixed for function, case and tailloop. Also fixed a test that relied on this incorrect behaviour. Closes #1257
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 87.42% 87.37% -0.06%
==========================================
Files 109 109
Lines 19799 19793 -6
Branches 17536 17530 -6
==========================================
- Hits 17310 17294 -16
- Misses 1723 1731 +8
- Partials 766 768 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
approved these changes
Jul 22, 2024
| } | ||
| } | ||
|
|
||
| impl From<BuildHandle<DfgID>> for BuildHandle<TailLoopID> { |
There was a problem hiding this comment.
Could we keep the implementation (dropping the loop flag output)?
There was a problem hiding this comment.
there may be some outputs embedded in the loop flag output in the "break" variant of the Sum.
Merged
aborgna-q
pushed a commit
that referenced
this pull request
Jul 25, 2024
DFGWrapper handles incorrectly were using internal dfg output number as the outputs from the container node. Fixed for function, case and tailloop. Also fixed a test that relied on this incorrect behaviour. Closes #1257
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
This is a patch release including only some non-breaking changes since 0.9.0. ## New release * `hugr`: 0.9.0 -> 0.9.1 * `hugr-core`: 0.6.0 -> 0.6.1 * `hugr-passes`: 0.6.0 -> 0.6.1 * `hugr-cli`: 0.2.0 -> 0.2.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.9.1 (2024-07-25) ### Bug Fixes - Dfg wrapper build handles incorrect output wire numbers ([#1332](#1332)) - Sibling extension panics while computing signature with non-dataflow nodes ([#1350](#1350)) </blockquote> ## `hugr-core` <blockquote> ## 0.6.1 (2024-07-25) ### Bug Fixes - Dfg wrapper build handles incorrect output wire numbers ([#1332](#1332)) - Sibling extension panics while computing signature with non-dataflow nodes ([#1350](#1350)) </blockquote> ## `hugr-passes` <blockquote> ## 0.6.1 (2024-07-25) Nothing here. </blockquote> ## `hugr-cli` <blockquote> ## 0.2.1 (2024-07-25) Nothing here. </blockquote> </p></details> --- This PR was generated by a human. --------- Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
ss2165
added a commit
that referenced
this pull request
Jul 26, 2024
This is a patch release including only some non-breaking changes since 0.9.0. ## New release * `hugr`: 0.9.0 -> 0.9.1 * `hugr-core`: 0.6.0 -> 0.6.1 * `hugr-passes`: 0.6.0 -> 0.6.1 * `hugr-cli`: 0.2.0 -> 0.2.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.9.1 (2024-07-25) ### Bug Fixes - Dfg wrapper build handles incorrect output wire numbers ([#1332](#1332)) - Sibling extension panics while computing signature with non-dataflow nodes ([#1350](#1350)) </blockquote> ## `hugr-core` <blockquote> ## 0.6.1 (2024-07-25) ### Bug Fixes - Dfg wrapper build handles incorrect output wire numbers ([#1332](#1332)) - Sibling extension panics while computing signature with non-dataflow nodes ([#1350](#1350)) </blockquote> ## `hugr-passes` <blockquote> ## 0.6.1 (2024-07-25) Nothing here. </blockquote> ## `hugr-cli` <blockquote> ## 0.2.1 (2024-07-25) Nothing here. </blockquote> </p></details> --- This PR was generated by a human. --------- Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
acl-cqc
added a commit
that referenced
this pull request
Aug 28, 2024
* DFContext reinstate fn hugr(), drop AsRef requirement (fixes StackOverflow) * test_tail_loop_iterates_twice: use tail_loop_builder_exts, fix from #1332(?) * Fix only-one-DataflowContext asserts using Arc::ptr_eq
acl-cqc
added a commit
that referenced
this pull request
Sep 2, 2024
* DFContext reinstate fn hugr(), drop AsRef requirement (fixes StackOverflow) * test_tail_loop_iterates_twice: use tail_loop_builder_exts, fix from #1332(?) * Fix only-one-DataflowContext asserts using Arc::ptr_eq
acl-cqc
added a commit
that referenced
this pull request
Sep 11, 2024
* DFContext reinstate fn hugr(), drop AsRef requirement (fixes StackOverflow) * test_tail_loop_iterates_twice: use tail_loop_builder_exts, fix from #1332(?) * Fix only-one-DataflowContext asserts using Arc::ptr_eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFGWrapper handles incorrectly were using internal dfg output number as the outputs from the container node. Fixed for function, case and tailloop. Also fixed a test that relied on this incorrect behaviour.
Closes #1257