Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Bring the collections ext in line with other extension defs #1469

Merged
merged 4 commits into from
Aug 27, 2024
Merged

refactor!: Bring the collections ext in line with other extension defs #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2565f73
Bring the collections ext in line with other extension defs
aborgna-q Aug 27, 2024
c675845
fix docs
aborgna-q Aug 27, 2024
e72e8dd
Cleanup unneeded method
aborgna-q Aug 27, 2024
9c646b3
Better test coverage
aborgna-q Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hugr-core/src/hugr/rewrite/replace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,21 +524,21 @@ mod test {
inputs: vec![listy.clone()].into(),
sum_rows: vec![type_row![]],
other_outputs: vec![listy.clone()].into(),
extension_delta: collections::EXTENSION_NAME.into(),
extension_delta: collections::EXTENSION_ID.into(),
},
);
let r_df1 = replacement.add_node_with_parent(
r_bb,
DFG {
signature: Signature::new(vec![listy.clone()], simple_unary_plus(intermed.clone()))
.with_extension_delta(collections::EXTENSION_NAME),
.with_extension_delta(collections::EXTENSION_ID),
},
);
let r_df2 = replacement.add_node_with_parent(
r_bb,
DFG {
signature: Signature::new(intermed, simple_unary_plus(just_list.clone()))
.with_extension_delta(collections::EXTENSION_NAME),
.with_extension_delta(collections::EXTENSION_ID),
},
);
[0, 1]
Expand Down
2 changes: 1 addition & 1 deletion hugr-core/src/hugr/validate/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ fn no_polymorphic_consts() -> Result<(), Box<dyn std::error::Error>> {
PolyFuncType::new(
[BOUND],
Signature::new(vec![], vec![list_of_var.clone()])
.with_extension_delta(collections::EXTENSION_NAME),
.with_extension_delta(collections::EXTENSION_ID),
),
)?;
let empty_list = Value::extension(collections::ListValue::new_empty(Type::new_var_use(
Expand Down
Loading
Loading