chore: Fix new lints in rust 1.83 #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 86.34% 86.34% -0.01%
==========================================
Files 166 166
Lines 29747 29747
Branches 26659 26659
==========================================
- Hits 25685 25684 -1
- Misses 2536 2537 +1
Partials 1526 1526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
reviewed
Nov 25, 2024
hugr-core/src/proptest.rs
Outdated
| pub fn any_nonempty_smolstr() -> SBoxedStrategy<SmolStr> { | ||
| ANY_NONEMPTY_STRING.to_owned().prop_map_into().sboxed() | ||
| } | ||
|
|
||
| /// A strategy for generating an arbitrary nonempty identity [String]. |
There was a problem hiding this comment.
What is an identity String?
aborgna-q
force-pushed
the
ab/rust-1.83
branch
from
def367b to
79c3a4c
Compare
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
cqc-alec
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rust coming on 2024-11-28. This PR fixes new lints that would make our CI runs fail.
A big noisy change is due to public test definitions now triggering the
missing_docslint.See rust-lang/rust#130025. This can be fixed avoided either by adding the docs or by making functions private.
Passing check: https://github.com/CQCL/hugr/actions/runs/12013283775/job/33486450494#step:7:1