-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simplify hugr-model #1893
Conversation
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
734502b
to
20246ce
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 86.56% 86.70% +0.14%
==========================================
Files 195 195
Lines 35724 35538 -186
Branches 32537 32351 -186
==========================================
- Hits 30925 30814 -111
+ Misses 3012 2951 -61
+ Partials 1787 1773 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e8816bc
to
510e008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking clean!
My main request is taking it out of the default features.
Btw, I'm fine with not marking this PR as breaking since it's only an unstable |
## 🤖 New release * `hugr`: 0.14.3 * `hugr-core`: 0.14.3 * `hugr-model`: 0.17.1 * `hugr-llvm`: 0.14.3 * `hugr-passes`: 0.14.3 * `hugr-cli`: 0.14.3 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.14.3](hugr-v0.14.2...hugr-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Fix deprecation warning messages (#1891) - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-core` <blockquote> ## [0.14.3](hugr-core-v0.14.2...hugr-core-v0.14.3) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-model` <blockquote> ## [0.17.1](hugr-model-v0.17.0...hugr-model-v0.17.1) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) - Do not require `capnp` to be installed to compile `hugr-model` (#1907) </blockquote> ## `hugr-llvm` <blockquote> ## [0.14.2](hugr-llvm-v0.14.1...hugr-llvm-v0.14.2) - 2025-01-20 ### New Features - *(hugr-llvm)* Emit more int ops (#1835) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) ### Refactor - *(hugr-llvm)* [**breaking**] Optimise the llvm types used to represent hugr sums. (#1855) ### Testing - Fix failing inot test (#1841) </blockquote> ## `hugr-passes` <blockquote> ## [0.14.3](hugr-passes-v0.14.2...hugr-passes-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) ### Documentation - Fix deprecation warning messages (#1891) </blockquote> ## `hugr-cli` <blockquote> ## [0.14.1](hugr-cli-v0.14.0...hugr-cli-v0.14.1) - 2024-12-18 ### New Features - Print `hugr-cli`'s correct version when using '--version' (#1790) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>
This PR simplifies
hugr_model
by moving every operation and term that can be defined as an extension to a core extension. This way we do not need special cases in the binary format, text format, validation (future), codegen (future), documentation generation (future). Closes #1900.