-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: ComposablePass trait allowing sequencing and validation #1895
Draft
acl-cqc
wants to merge
13
commits into
main
Choose a base branch
from
acl/composable_pass
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 86.56% 86.52% -0.04%
==========================================
Files 195 195
Lines 35724 35736 +12
Branches 32537 32549 +12
==========================================
- Hits 30925 30922 -3
- Misses 3012 3027 +15
Partials 1787 1787
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several "passes" atm: monomorphization, dead function removal, constant folding. Each has its own code to allow setting a validation level (before and after that pass).
This PR adds the ability chain (sequence) passes;, and to add validation before+after any pass or sequence; and commons up validation code. The top-level
constant_fold_pass
(etc.) functions are left as wrappers that do a single pass with validation only in test.TODO: no actual tests of sequencing yet, heh! Maybe we could combine, hmmm, monomorphization followed by constant folding?
BREAKING CHANGE: quite a lot of calls to current pass routines will break, specific cases include (a)
with_validation_level
should be done by wrapping a ValidatingPass around the receiver; (b) XXXPass::run() requiresuse ...ComposablePass
(however, such calls will cease to do any validation).