Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hugr-passes)!: Add UnNonLocalPass #1912

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

feat(hugr-passes)!: Add UnNonLocalPass #1912

wants to merge 25 commits into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Feb 6, 2025

BREAKING CHANGE: TODO deets, changed NonLocalEdgesError

@doug-q doug-q changed the title feat!: Add UnNonLocalPass feat(hugr-passes)!: Add UnNonLocalPass Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 96.50838% with 25 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (8de6c7b) to head (6dabc6b).

Files with missing lines Patch % Lines
hugr-passes/src/non_local.rs 96.50% 21 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
+ Coverage   83.78%   84.04%   +0.25%     
==========================================
  Files         196      196              
  Lines       37470    38186     +716     
  Branches    34283    34999     +716     
==========================================
+ Hits        31396    32092     +696     
- Misses       4296     4310      +14     
- Partials     1778     1784       +6     
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 83.28% <96.50%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugrbot
Copy link
Collaborator

hugrbot commented Feb 6, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
      ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/auto_trait_impl_removed.ron

Failed in:
type NonLocalEdgesError is no longer UnwindSafe, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:70
type NonLocalEdgesError is no longer RefUnwindSafe, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:70

--- failure derive_trait_impl_removed: built-in derived trait no longer implemented ---

Description:
A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits.
      ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/derive_trait_impl_removed.ron

Failed in:
type NonLocalEdgesError no longer derives Clone, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:70
type NonLocalEdgesError no longer derives Eq, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:70

--- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] ---

Description:
A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_marked_non_exhaustive.ron

Failed in:
enum NonLocalEdgesError in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/non_local.rs:70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants