Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Rename Alias/Func Def/Decl nodes #232

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Conversation

acl-cqc
Copy link
Contributor

@acl-cqc acl-cqc commented Jun 30, 2023

Def => FuncDefn
Declare => FuncDeclare (there are a couple of uses of "Declare" as a verb that I've preserved)
Alias => AliasDefn
AliasDeclare => AliasDecl

Also update spec.

@acl-cqc acl-cqc requested a review from ss2165 June 30, 2023 09:18
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like Decl/Defn for length

@acl-cqc acl-cqc changed the title [refactor] Rename Def=>FuncDef, Declare=>FuncDeclare [refactor] Rename Alias/Func Def/Decl nodes Jun 30, 2023
@acl-cqc acl-cqc requested a review from ss2165 June 30, 2023 10:51
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acl-cqc acl-cqc merged commit e6abc02 into main Jun 30, 2023
@acl-cqc acl-cqc deleted the refactor/func_def_declare branch June 30, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants