Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new + bugfix] replace_op checks bound, adding HugrError::InvalidTag #581

Merged
merged 5 commits into from
Oct 2, 2023
Merged

[new + bugfix] replace_op checks bound, adding HugrError::InvalidTag #581

merged 5 commits into from
Oct 2, 2023

Conversation

acl-cqc
Copy link
Contributor

@acl-cqc acl-cqc commented Sep 29, 2023 •
edited
Loading

  • Add HugrError::InvalidTag, use in HierarchyView::try_new and SiblingMut::try_new
  • In HugrMut::replace_op, check that changing the root-node's op does not invalidate the Root: NodeHandle tag.
  • Hence, make HugrMut::replace_op return a Result

@acl-cqc acl-cqc requested a review from aborgna-q September 29, 2023 11:06
@acl-cqc acl-cqc mentioned this pull request Sep 29, 2023
Merged
aborgna-q
aborgna-q approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acl-cqc acl-cqc added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit bb09fd4 Oct 2, 2023
@acl-cqc acl-cqc deleted the new/replace_op_checks_bound branch October 2, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acl-cqc @aborgna-q