Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make FuncDecl/FuncDefn polymorphic #692

Merged
merged 28 commits into from
Nov 21, 2023
Merged

feat: make FuncDecl/FuncDefn polymorphic #692

merged 28 commits into from
Nov 21, 2023

Commits on Nov 13, 2023

  1. FuncDefn/FuncDecl store PolyFuncType - some horrendous hacks with // … 

    …ALAN
    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0de995f View commit details
    Browse the repository at this point in the history

  2. build_main/define_function take PolyFuncType not Signature, but tail_… 

    …loop test
    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6c0edbb View commit details
    Browse the repository at this point in the history

  3. extract_subgraph and FunctionBuilder::new take PolyFuncType not Signa… 

    …ture
    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    3078259 View commit details
    Browse the repository at this point in the history

  4. believe define_declaration is correct, but refactor a bit

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    271a15a View commit details
    Browse the repository at this point in the history

  5. declare (FuncDecl) takes PolyFuncType

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b781155 View commit details
    Browse the repository at this point in the history

  6. builder fn call takes TypeArgs - and ExtensionRegistry, ugh

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    c56e8c2 View commit details
    Browse the repository at this point in the history

  7. validate_children: return early if no children

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9fd164b View commit details
    Browse the repository at this point in the history

  8. validate_children=>validate_subtree, breaking more tests (wrong choic… 

    …e among multiple Err's)
    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    78316a1 View commit details
    Browse the repository at this point in the history

  9. Separate validate_subtree

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9c3048a View commit details
    Browse the repository at this point in the history

  10. Revert "validate_children: return early if no children" 

    This reverts commit 9fd164b.
    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    9cb43a1 View commit details
    Browse the repository at this point in the history

  11. Properly check that args to binary compute_signature have no type vars

    @acl-cqc
    acl-cqc committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    41f0970 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Don't implement TypeParametrised for OpDef

    @acl-cqc
    acl-cqc committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    793a00c View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Remove comments - those were correct changes

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c55019c View commit details
    Browse the repository at this point in the history

  2. fix doclink

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    6f5526f View commit details
    Browse the repository at this point in the history

  3. Merge 'origin/main' into new/poly_funcdeclfn

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2fa23e9 View commit details
    Browse the repository at this point in the history

  4. Add PolyFuncType::new, make validate public

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9a656d9 View commit details
    Browse the repository at this point in the history

  5. validate_port from validate_subtree not validate_node; some tests

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    293b663 View commit details
    Browse the repository at this point in the history

  6. Finally give in and add "impl From<TypeBound> for TypeParam"

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d9da463 View commit details
    Browse the repository at this point in the history

  7. Test (and comment) re. nested FuncDefns

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    3652d56 View commit details
    Browse the repository at this point in the history

  8. Comments re. Dataflow::call()

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d2e281b View commit details
    Browse the repository at this point in the history

  9. Avoid Itertools::Either - can use ExternalOp

    @acl-cqc
    acl-cqc committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    de374c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Update since-1.75 test

    @acl-cqc
    acl-cqc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9b23560 View commit details
    Browse the repository at this point in the history

  2. Provide a BuildError::SignatureError variant

    @acl-cqc
    acl-cqc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9b0b5b9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into new/poly_funcdeclfn

    @acl-cqc
    acl-cqc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    44166ce View commit details
    Browse the repository at this point in the history

  4. Comment re FuncDefn::validate_op_children

    @acl-cqc
    acl-cqc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f069c92 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. CANNOT use type vars from enclosing defn's

    @acl-cqc
    acl-cqc committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c3d4c83 View commit details
    Browse the repository at this point in the history

  2. Test no_polymorphic_consts, enforce no TVs on Static edges, add ListV… 

    …alue::new
    @acl-cqc
    acl-cqc committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    95ddb36 View commit details
    Browse the repository at this point in the history

  3. wth -> with

    @acl-cqc
    acl-cqc committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    7e8c515 View commit details
    Browse the repository at this point in the history