feat: Rust semver-checks workflow against base branch #13
Conversation
aborgna-q
force-pushed
the
ab/semver-checks
branch
5 times, most recently
from
13ede8f
to
1b4d6fb
Compare
aborgna-q
force-pushed
the
ab/semver-checks
branch
from
1b4d6fb
to
b3b00b5
Compare
|
It should be working now! |
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: PR_BRANCH | ||
| - name: Checkout baseline |
There was a problem hiding this comment.
Seems the most useful is to be able to test against the last tagged commit (possibly with the tag matching some pattern), is that possible?
There was a problem hiding this comment.
That's the default behaviour, and it's actually what semver-checks-action does.
The problem is that the output is not really useful for the PR author, as once a breaking change gets merged will reappear as noise on every subsequent PR.
We'll still get the aggregated comparison against the last release on the release-plz PR, so no need to repeat it here.
s-c-action plans to add the baseline checks at some point, but it requires some changes to its definition first.
See the discussion in obi1kenobi/cargo-semver-checks-action#64
For now the alternative is to manually run semver-checks, as we do here.
There was a problem hiding this comment.
Got it, I agree that release-plz is handling my problem
aborgna-q
changed the title
aborgna-q
changed the title
Run `cargo-ci-checks` on each PR, and add a comment with the output if there are breaking changes. See CQCL/hugrverse-actions#13 drive-by: Allow forcing the checks to run by adding a `run-ci-checks` label to the PR. Imported from tket2. https://github.com/CQCL/tket2/blob/740b3ec20f7d3889162c935a47cd0de9ba250a45/.github/workflows/ci.yml#L44 <img width="894" alt="image" src="https://github.com/user-attachments/assets/10748599-e2ab-46fa-979f-d8246c203d5a">
Test PR: CQCL/hugr#1598
Limitations:
!flag).It will only change when a new commit is pushed.