Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception when applying ansatze on a diagram with frames #222

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Raise an exception when applying ansatze on a diagram with frames #222

merged 4 commits into from
Feb 28, 2025

Conversation

neiljdo
Copy link
Collaborator

@neiljdo neiljdo commented Feb 27, 2025

Fixes #220

@neiljdo neiljdo marked this pull request as draft February 27, 2025 14:05
@neiljdo neiljdo marked this pull request as ready for review February 27, 2025 15:04
@neiljdo neiljdo requested a review from dimkart February 27, 2025 15:05
@neiljdo neiljdo marked this pull request as draft February 27, 2025 15:09
@neiljdo neiljdo marked this pull request as ready for review February 27, 2025 15:57
dimkart
dimkart reviewed Feb 27, 2025
View reviewed changes
dimkart
dimkart reviewed Feb 27, 2025
View reviewed changes
dimkart
dimkart approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@dimkart dimkart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, but apart of that it's ready to go!

@neiljdo neiljdo requested a review from dimkart February 28, 2025 10:31
@neiljdo neiljdo merged commit 0d7eebd into CQCL:main Feb 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimkart dimkart dimkart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisCoCirc: Add warning when applying ansatze on a diagram with frames
2 participants
@neiljdo @dimkart