More validation: require data_type in cvar_define
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
changed the title
data_type in cvar_define
qartik
force-pushed
the
more-validation
branch
from
7a12901 to
8f7f24d
Compare
qartik
changed the title
data_type in cvar_definedata_type in cvar_define
qartik
force-pushed
the
more-validation
branch
from
f3620c2 to
72ccbb0
Compare
qciaran
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13 and restricts classical variables' data type to be one of
"i64","i32","u64", and"u32".EDIT: I merged non-spec changes in #15