feat: Use FullyConnected architecture #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Braket has a field to indicate that a device is fully connected that maps well onto the pytket FullyConnected architecture. This commit changes the utility function that converts between the two models to make use of this. This will change the BackendInfo returned by simulators or devices with full connectivity.
cqc-alec
reviewed
Apr 4, 2024
| @@ -494,6 +494,8 @@ def _get_arch_info( | |||
| connectivity = paradigm["connectivity"] | |||
| if connectivity["fullyConnected"]: | |||
| all_qubits: List = list(range(n_qubits)) | |||
| arch = FullyConnected(len(all_qubits)) | |||
| return arch, all_qubits | |||
There was a problem hiding this comment.
It looks like there is another place (l.516 below) where we could make this change?
|
Hmm, looks like some tests are failing. Maybe this is a bit more complicated. |
cqc-alec
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Braket has a field to indicate that a device is fully connected that maps well onto the pytket FullyConnected architecture. This commit changes the utility function that converts between the two models to make use of this. This will change the BackendInfo returned by simulators or devices with full connectivity.
Related issues
N/A
Checklist