Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created IQM_SCHEMA #153

Merged
merged 10 commits into from
Jul 5, 2024
Merged

created IQM_SCHEMA #153

merged 10 commits into from
Jul 5, 2024

Conversation

yoshi-qc
Copy link
Contributor

IQM_SCHEMA is created.

Description

Please summarise the changes.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@yoshi-qc
created IQM_SCHEMA
d5c4b33 
IQM_SCHEMA is created.
@yoshi-qc yoshi-qc requested a review from cqc-alec as a code owner June 27, 2024 11:07
@yoshi-qc yoshi-qc linked an issue Jun 27, 2024 that may be closed by this pull request
Access IQM device from Amazon Braket #152
Closed
@yoshi-qc
created IQM_SCHEMA
d1a2cfb 
IQM_SCHEMA is created
@yoshi-qc
created IQM_SCHEMA
5f285d6 
IQM_SCHEMA is created
@yoshi-qc
created IQM_SCHEMA
9f39e1f 
IQM_SCHEMA is created
@yoshi-qc
created IQM_SCHEMA
b1c3fc1 
IQM_SCHEMA is created
cqc-alec
cqc-alec requested changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests using this backend in backend_test.py please?

@yoshi-qc
create IQM backend test
059dde5 
create IQM backend test
@yoshi-qc
Copy link
Contributor Author

yoshi-qc commented Jul 1, 2024

I made a test for the IQM backend in backend_test.py.

cqc-alec
cqc-alec reviewed Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to test this because the device is offline (and so the test in the CI is skipped). Have you successfully run a circuit on the device?

pytket/extensions/braket/backends/braket.py Show resolved Hide resolved
@yoshi-qc
Update setup.py
30e5382 
update the minimum version of amazon-braket-schemas to >= 1.22.0.
@yoshi-qc
Edit the functions of arch_info and backend_info
88da601 
IQM device on Braket (20 qubits device) accepts a circuit with node labeling from 0 to 19. I edited the files '_get_arch_info' and '_get_backend_info'.
@yoshi-qc
Edit the function "_get_arch_info"
2bba54d 
moved the code "schema = device_properties["provider"]["braketSchemaHeader"]"
@yoshi-qc
Copy link
Contributor Author

yoshi-qc commented Jul 4, 2024

I re-ran the build and test module on ubuntu, macos, and win in github and I found that the function test_iqm (the 9th function in backend_test.py) is passed.

@cqc-alec cqc-alec merged commit 107c4da into main Jul 5, 2024
7 checks passed
@cqc-alec cqc-alec deleted the iqm/Garnet branch July 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access IQM device from Amazon Braket
2 participants
@yoshi-qc @cqc-alec