-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example notebook for braket setup and simple circuit #61
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a good idea!
There is a minor formatting issue that should be solved by running the black
formatter on the new python file.
Apart from that, I think the instructions should be modified so that the user doesn't create their own plaintext credentials file -- see comment. With the AWS method one doesn't have to explicitly pass in this file. Unless there are some use cases where that doesn't work?
Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by |
Yes it seems to be coming from the long lines. Can you wrap the lines at 80 characters. or does that break the p2j conversion? If necessary we can exclude the folder from the link check. |
Yes, |
Actually they are not excluded there, and the python files do contain long lines (e.g. https://github.com/CQCL/pytket-quantinuum/blob/develop/examples/python/Quantinuum_circuit_submissions.py ), so I am not sure what's different here... |
I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off? |
Sure, I think it's just some linting issues to fix? |
Please rebase and retarget to |
Amazon braket documentation is sometimes not very clear, and
pytket-braket
doesn't have as much documentation as some otherpytket
extensions. This notebook is based on a Confluence page I wrote for our team and on a notebook by Callum. I have used the notebook template and generation frompytket-quantinuum
.