Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend gate set updated. #23

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Backend gate set updated. #23

merged 5 commits into from
Jul 26, 2023

Conversation

yapolyak
Copy link
Contributor

Allowed for much wider gate set. Improved on the passes and predicates.

@yapolyak
Copy link
Contributor Author

All tests pass locally.

PabloAndresCQ
PabloAndresCQ requested changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a test with circuits using gates with >2 qubits? Say, some CCX, CSWAP and CnZ with n>3.

PabloAndresCQ
PabloAndresCQ approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gateset has been freed, I am content.

@yapolyak yapolyak merged commit 7eefaa1 into develop Jul 26, 2023
6 checks passed
@yapolyak yapolyak deleted the gateset_redone branch July 26, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloAndresCQ PabloAndresCQ PabloAndresCQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yapolyak @PabloAndresCQ