Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/workflow 2023 #64

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Fix/workflow 2023 #64

merged 4 commits into from
Jan 9, 2024

Conversation

cqc-melf
Copy link
Collaborator

Description

Please summarise the changes.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@PabloAndresCQ
Copy link
Collaborator

PabloAndresCQ commented Jan 4, 2024

@cqc-melf It seems the error we got on the 0.5.2 release workflow on the doc publishing is related to this deploy-pages issue. They say this should be fixed by deploy-pages v4.0.1. Do we need to bump deploy-pages@v4 to deploy-pages@v4.0.1 in this build_and_test.yml file, or should that happen somewhere else?

@cqc-melf
Copy link
Collaborator Author

cqc-melf commented Jan 8, 2024

@cqc-melf It seems the error we got on the 0.5.2 release workflow on the doc publishing is related to this deploy-pages issue. They say this should be fixed by deploy-pages v4.0.1. Do we need to bump deploy-pages@v4 to deploy-pages@v4.0.1 in this build_and_test.yml file, or should that happen somewhere else?

I think we should do that in a separate PR, that needs to be done on the other repos as well and it is easier to do that all at once for me

@cqc-melf cqc-melf merged commit fa7bf44 into develop Jan 9, 2024
6 checks passed
@PabloAndresCQ PabloAndresCQ mentioned this pull request Jan 10, 2024
5 tasks
@PabloAndresCQ PabloAndresCQ deleted the fix/workflow-2023 branch January 10, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants