Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pr49 #50

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Feature/pr49 #50

merged 4 commits into from
Mar 28, 2023

Conversation

cqc-alec
Copy link
Collaborator

No description provided.

@cqc-alec
Copy link
Collaborator Author

@ollityrkko I replicated your PR here to allow the github secrets to be accessed ...

@cqc-alec
Copy link
Collaborator Author

@ollityrkko It looks like there is a connection error; do we need to update the credentials?

@ollityrkko
Copy link
Contributor

ollityrkko commented Mar 28, 2023 via email

@cqc-alec
Copy link
Collaborator Author

I believe the problem is with the auth server URL which has changed. I made the corresponding change in README. Auth server URL is apparently stored also in the secrets.

Right, thanks, I'll update the URL in the secrets...

@cqc-alec cqc-alec requested a review from cqc-melf March 28, 2023 14:37
@cqc-alec
Copy link
Collaborator Author

Thanks for the fixes, this looks good to me.

Copy link
Collaborator

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we do a release soon?

@cqc-alec
Copy link
Collaborator Author

Looks good, should we do a release soon?

Yes I think so.

@cqc-alec cqc-alec merged commit 0e3751a into develop Mar 28, 2023
@cqc-alec cqc-alec deleted the feature/pr49 branch March 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants