-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/measure to reg #87
Conversation
Given the interface in #61 (review) perhaps a better name might be |
I have done a rename to |
Hi @cqc-melf, it's not clear to me from a quick look whether If it's a single bit (that I suspect from the third argument of creg index), then the name could be misleading. In that case, I'd prefer it be called |
Yes the plan is to measure one qubit to the bit entry of a register, I have added an additional comment and renamed like suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I will let @peter-campora chip in as well before approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mz_to_creg_bit
is a name that works for me. Will add support for it in L3 soon!
Not sure what the name is er agreed on, happy to update this.