Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/measure to reg #87

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Feature/measure to reg #87

merged 6 commits into from
Oct 31, 2023

Conversation

cqc-melf
Copy link
Collaborator

Not sure what the name is er agreed on, happy to update this.

@cqc-melf cqc-melf marked this pull request as ready for review October 24, 2023 10:58
pytket/qir/conversion/conversion.py Outdated Show resolved Hide resolved
@qartik
Copy link
Member

qartik commented Oct 24, 2023

Not sure what the name is er agreed on

Given the interface in #61 (review) perhaps a better name might be measure_to_creg or mz_to_creg in short?

@cqc-melf
Copy link
Collaborator Author

Not sure what the name is er agreed on

Given the interface in #61 (review) perhaps a better name might be measure_to_creg or mz_to_creg in short?

I have done a rename to mz_to_creg

@cqc-melf cqc-melf requested a review from qartik October 25, 2023 14:47
@qartik
Copy link
Member

qartik commented Oct 25, 2023

Hi @cqc-melf, it's not clear to me from a quick look whether mz_to_creg is supposed to measure a single qubit or a register of qubits or both. Can you clarify?

If it's a single bit (that I suspect from the third argument of creg index), then the name could be misleading. In that case, I'd prefer it be called mz_to_creg_bit.

@cqc-melf
Copy link
Collaborator Author

Yes the plan is to measure one qubit to the bit entry of a register, I have added an additional comment and renamed like suggested

Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I will let @peter-campora chip in as well before approval.

Copy link

@peter-campora peter-campora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mz_to_creg_bit is a name that works for me. Will add support for it in L3 soon!

@cqc-melf cqc-melf merged commit 2e92a9a into develop Oct 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants