-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversion of controlled unitary gates from Qiskit to TKET. #372
Conversation
Hi @gkpotter |
I think its just a case of running the black formatter on the qiskit convert file black qiskit_convert.py |
Oops sorry about that. Just re-ran black on |
Looks good, I have run the checks locally and they all work. It would be nice to add the conversion in the other direction, too. If you don't have the time to do that, I will add an issue for that and try to do it in the near future. If you don't want to add the other direction, please update the changelog and I am happy to approve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
I updated the changelog. Unfortunately, right now I do not have time to implement conversion in the other direction. |
I have added an issue for that, #378 |
Description
Add support for converting controlled unitary gates from Qiskit to TKET.
Related issues
Please mention any github issues addressed by this PR.
Checklist
Notes
I have yet to update the changelog/API docs, in case more changes or refactoring are required.