Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

update qsharp to 1.0.33 #78

Closed
wants to merge 2 commits into from
Closed

update qsharp to 1.0.33 #78

wants to merge 2 commits into from

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Jan 12, 2024

Description

Please summarise the changes.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-melf
Copy link
Collaborator Author

My understanding is that it should be possible to remove the dotnet dependency after this, but it doesn't work yet. I think this misses the releases of additional packages. Happy to do this now and the clean up later, or both later together.

@cqc-melf cqc-melf marked this pull request as ready for review January 12, 2024 12:59
@cqc-alec
Copy link
Collaborator

My understanding is that it should be possible to remove the dotnet dependency after this, but it doesn't work yet. I think this misses the releases of additional packages. Happy to do this now and the clean up later, or both later together.

We can do that later. Could you make an issue?

@@ -45,7 +45,7 @@
include_package_data=True,
install_requires=[
"pytket ~= 1.23",
"qsharp ~= 0.28.291394",
"qsharp ~= 1.0.33",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"qsharp ~= 1.0.33",
"qsharp ~= 1.0",

Further 1.x releases shouldn't break compatibility.

unreleased
----------

* Updated qsharp version requirement to 1.0.33.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Updated qsharp version requirement to 1.0.33.
* Updated qsharp version requirement to 1.0.

@cqc-melf
Copy link
Collaborator Author

My understanding is that it should be possible to remove the dotnet dependency after this, but it doesn't work yet. I think this misses the releases of additional packages. Happy to do this now and the clean up later, or both later together.

We can do that later. Could you make an issue?

I have created an issue at #76 and will close this

@cqc-melf cqc-melf closed this Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants