Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch protection rules prevent PRs that don't change tket or pytket from being merged #1115

Closed
cqc-alec opened this issue Nov 8, 2023 · 3 comments · Fixed by #1123
Closed
Labels
bug Something isn't working

Comments

@cqc-alec
Copy link
Collaborator

cqc-alec commented Nov 8, 2023

The issue is the "build and test pytket (macos)" job, which is required, and should be skipped in such cases. For some reason, while the job is not run, the PR does not show it as skipped but as waiting for a runner (indefinitely), preventing merging.

For an example see this PR: #1114 .

@cqc-alec cqc-alec added the bug Something isn't working label Nov 8, 2023
@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Nov 8, 2023

Required status checks:
image

@trvto
Copy link
Contributor

trvto commented Nov 13, 2023

This happens because some weird naming stuff when you use the matrix strategy. There is already a workaround implemented for the tket build. See job build_test_tket_not_required. If you add something similar for the pytket macos builds, should work.

@trvto
Copy link
Contributor

trvto commented Nov 13, 2023

Another possibility to fix this (which I personally find better) is to add a job at the end of the workflow file that fails if any other job fails. See https://github.com/CQCL/pytket-aqt/blob/develop/.github/workflows/tests.yml#L101 for an example. If you have such a job, you can configure github to only have it as a required check (for that workflow file). Which makes things a lot nicer I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants