Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job to check all build and test jobs successful #1123

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

trvto
Copy link
Contributor

@trvto trvto commented Nov 13, 2023

Fixes #1115, also see comments there

Added a job to build and test workflow whose only job is to check that all other jobs did not explicitly fail or were not canceled (skipped jobs are ok). How this fixes the problem:

  • After merging, only use the new job as a required check in the github settings -> No longer need to define a required check for the individual jobs
  • No longer have to worry about naming issues that occur with matrix strategy jobs

After merging: In a follow-up PR, should be able to remove the dummy job build_test_tket_not_required since it should no longer be required

@trvto trvto requested a review from cqc-alec November 13, 2023 17:50
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trvto trvto merged commit 48394a0 into develop Nov 14, 2023
31 checks passed
@trvto trvto deleted the add-build-and-test-ci-required-check-helper branch November 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch protection rules prevent PRs that don't change tket or pytket from being merged
2 participants